Attila Jeges has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14043 )

Change subject: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2.
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2
> nit: I would prefer something more descriptive like "(Hive3) Use 'engine' f
Done


http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@7
PS4, Line 7: part 1
> What does part 1 mean? Will there be additional changes after part 1 step 4
This is step 2 in a series of steps that involves both Hive and Impala.

IMPALA-8842 covers the Impala related steps, that is: step 2 and step 4.

so step 2 is part 1 of IMPALA-8842, while step 4 will be part 2.

If you think this is too confusing, I could remove "part 1" from the summary. 
Or maybe I should remove "Step 2" from the end of the summary line?


http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@40
PS4, Line 40:
> About testing: there were EE tests in https://gerrit.cloudera.org/#/c/14032
So far only step 1 has been merged in on the Hive side:

"New APIs will simply call old existing methods so there should not be any 
change of functionality there."

Since there's no new functionality, no new tests are needed. I'll add E2E tests 
in Step 4.



--
To view, visit http://gerrit.cloudera.org:8080/14043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4
Gerrit-Change-Number: 14043
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <atti...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 14:29:07 +0000
Gerrit-HasComments: Yes

Reply via email to