Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 )
Change subject: IMPALA-8842 part 1: (Hive3) Use 'engine' field in HMS stat API ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14043/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14043/7//COMMIT_MSG@14 PS7, Line 14: This change is Step 2 in a series of steps to coordinate the : introduction of HMS API changes to Hive3 and Impala. Step 4 is also : Impala related, it will be covered in IMPALA-8842 part 2. : : The steps are as follows: : : 1. Change in Hive3. : We push new APIs so Impala can use them. New APIs will simply call old : existing methods so there should not be any change of functionality : there. Since there were many incompatible changes, new APIs are tagged : method_name_V2. : : 2. Change in Impala. : Push changes to use new methods *V2. : : 3. Change in Hive3. : Push patch with complete functionality. *V2 methods contains the new : logic. The old existing methods are not used anymore by Impala at this : point, hence they can be removed. For every method_name_V2, I will : create a corresponding method method_name that calls the former one. : : 4. Change in Impala : Replace *V2 calls by *. : : 5. Change in Hive3. : Remove *V2 methods from API > I also wanted to explain why there's no change in functionality yet. I am okay with this. This should not block the commit. -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Aug 2019 18:24:08 +0000 Gerrit-HasComments: Yes
