Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14066 )
Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables ...................................................................... Patch Set 4: (2 comments) Fixed Hive 2 build and some Hive 3 tests. DROP STATS broke for some reason for non-transactional tables, I am investigating what happened. Here are the results of a test run: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/41/ http://gerrit.cloudera.org:8080/#/c/14066/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14066/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1017 PS2, Line 1017: msTbl.getParameters().remove(StatsSetupConst.COLUMN_STATS_ACCURATE); > Just remove the property from parameters. "false" is not a valid value. T Done http://gerrit.cloudera.org:8080/#/c/14066/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3809 PS2, Line 3809: // not always needed + the writeId of the INSERT could be probably reused. > In order not to leak resources, Is that possible transaction ID is not vali It should be valid, I added a Precondition. -- To view, visit http://gerrit.cloudera.org:8080/14066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c06b4678c1ff75c5aa1586a78afea563e64057f Gerrit-Change-Number: 14066 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Aug 2019 18:29:24 +0000 Gerrit-HasComments: Yes
