Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 )
Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14101/2/be/src/exec/exchange-node.cc File be/src/exec/exchange-node.cc: http://gerrit.cloudera.org:8080/#/c/14101/2/be/src/exec/exchange-node.cc@162 PS2, Line 162: stream_recvr_->CancelStream(); > does this mess up some of the logging done in KrpcDataStreamMgr::Cancel? it Reworded that log statement a bit to clarify the situation. We want to close the receiver without unregistering it so incoming senders won't hang. In fact, the same can already happen today if a fragment instance is first cancelled before being closed. http://gerrit.cloudera.org:8080/#/c/14101/2/tests/custom_cluster/test_exchange_eos.py File tests/custom_cluster/test_exchange_eos.py: http://gerrit.cloudera.org:8080/#/c/14101/2/tests/custom_cluster/test_exchange_eos.py@40 PS2, Line 40: @CustomClusterTestSuite.with_args(cluster_size=9, num_exclusive_coordinators=1) > is there a simpler cluster setup that re-produces this issue? e.g. with a s I tried with a smaller cluster size but couldn't quite reproduce it reliably. http://gerrit.cloudera.org:8080/#/c/14101/2/tests/custom_cluster/test_exchange_eos.py@57 PS2, Line 57: results = client.fetch(query, handle) > nit: validate the fetch was successful and close the query handle? Done -- To view, visit http://gerrit.cloudera.org:8080/14101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10c805e9d63ed8af9f458bf71e8ef5ea9376b939 Gerrit-Change-Number: 14101 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2019 21:51:06 +0000 Gerrit-HasComments: Yes
