Yongzhi Chen has uploaded a new patch set (#2) to the change originally created by Tim Armstrong. ( http://gerrit.cloudera.org:8080/14096 )
Change subject: IMPALA-7027: fix StringLiteral.localEquals() ...................................................................... IMPALA-7027: fix StringLiteral.localEquals() String literals with the same value but different types are not interchangeable. localEquals() should check the type, similar to a cast expression. Testing: - Added String literals tests. - Passed exhaustive tests. Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 --- M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java A testdata/workloads/functional-query/queries/QueryTest/string-literals.test M tests/query_test/test_chars.py 3 files changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14096/2 -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
