Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 )
Change subject: IMPALA-8858: Add observability of idle executor groups ...................................................................... Patch Set 2: (1 comment) A thing I thought of last night http://gerrit.cloudera.org:8080/#/c/14103/2/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/14103/2/be/src/scheduling/cluster-membership-mgr.cc@606 PS2, Line 606: idle_groups_->SetValue(idle_groups_str); I think this means that when there are no idle groups then this will be "" empty string? I'm worried that in all the stages we have to go through, impala->metrics_prometheus->prometheus->autoscaler that somewhere we will lose a metric with value "". Would it be horrible to have the value be "none" in this case? -- To view, visit http://gerrit.cloudera.org:8080/14103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539 Gerrit-Change-Number: 14103 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2019 15:50:31 +0000 Gerrit-HasComments: Yes
