Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12621 )
Change subject: IMPALA-8253: Draft - Parquet delta encoding and decoding. ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/12621/14/be/src/util/bit-packing.cc File be/src/util/bit-packing.cc: http://gerrit.cloudera.org:8080/#/c/12621/14/be/src/util/bit-packing.cc@63 PS14, Line 63: #define INSTANTIATE_UNPACK_AND_DELTA_DECODE(OUT_TYPE, PARQUET_TYPE) \ line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/12621/14/be/src/util/bit-packing.cc@65 PS14, Line 65: BitPacking::UnpackAndDeltaDecodeValues<OUT_TYPE>(int bit_width, \ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/12621/14/be/src/util/bit-packing.cc@67 PS14, Line 67: PARQUET_TYPE delta_offset, int64_t num_values, OUT_TYPE* __restrict__ out, int64_t stride, \ line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7378ac1a490a6c89a0a4349aae86cbc0fbc80f8 Gerrit-Change-Number: 12621 Gerrit-PatchSet: 14 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Aug 2019 16:43:23 +0000 Gerrit-HasComments: Yes