Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14133 )

Change subject: IMPALA-8889: Fix error messages for unsupported operations on 
acid tables
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

The code looks good to me, but I do not understand some parts of the commit 
message.

http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG@9
PS1, Line 9: uptodate
typo?


http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG@10
PS1, Line 10: Makes minor code change after HIVEMANAGEDINSERTWRITE is enabled.
I do not understand what this means. Can you add more detail?



--
To view, visit http://gerrit.cloudera.org:8080/14133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe
Gerrit-Change-Number: 14133
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 13:22:24 +0000
Gerrit-HasComments: Yes

Reply via email to