Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 )
Change subject: Fix THttpServer to not call the cookie function with an empty cookie ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14149/1/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/14149/1/be/src/transport/THttpServer.cpp@179 PS1, Line 179: if (!cookie_value_.empty()) { Maybe leave a one line comment to explain the significance of the check, so that future people don't attempt to simplify it :) -- To view, visit http://gerrit.cloudera.org:8080/14149 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e96fe97baae474a82fd30f2cd55ccce80570b4 Gerrit-Change-Number: 14149 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2019 17:08:12 +0000 Gerrit-HasComments: Yes
