Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14144 )
Change subject: IMPALA-8890: Advance read page in UnpinStream ...................................................................... IMPALA-8890: Advance read page in UnpinStream Fixes a DCHECK in BufferedTupleStream::UnpinStream where ExpectedPinCount would fail if the stream still referenced a read page that had be completely read. The patch changes UnpinStream so that if the current read page has been completely read, the read page is advanced using NextReadPage(). Testing: * Ran core tests * Added new tests to buffered-tuple-stream-test Change-Id: Id61a82559fd2baab237cc44f60a69cba2b30c16e Reviewed-on: http://gerrit.cloudera.org:8080/14144 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/analytic-eval-node.cc M be/src/exec/grouping-aggregator-partition.cc M be/src/exec/grouping-aggregator.cc M be/src/exec/grouping-aggregator.h M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-node.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/buffered-tuple-stream.cc M be/src/runtime/buffered-tuple-stream.h M be/src/runtime/spillable-row-batch-queue.cc 10 files changed, 114 insertions(+), 29 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id61a82559fd2baab237cc44f60a69cba2b30c16e Gerrit-Change-Number: 14144 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
