Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14164 )

Change subject: IMPALA-8738: Extend "show tables" to return values other than 
the table name
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/14164/2/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/14164/2/be/src/service/client-request-state.cc@306
PS2, Line 306:       RETURN_IF_ERROR(frontend_->GetTableNames(params->db, 
table_name, params->is_extended,
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/14164/2/be/src/service/frontend.cc
File be/src/service/frontend.cc:

http://gerrit.cloudera.org:8080/#/c/14164/2/be/src/service/frontend.cc@175
PS2, Line 175:     const bool &is_extended, const TSessionState* session, 
TGetTablesResult* table_names) {
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/14164/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java
File fe/src/main/java/org/apache/impala/service/JniFrontend.java:

http://gerrit.cloudera.org:8080/#/c/14164/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@252
PS2, Line 252:         PatternMatcher.createHivePatternMatcher(params.pattern), 
user, params.is_extended);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/14164/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/14164/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java@264
PS2, Line 264:               "MANAGED_TABLE", "MANAGED_TABLE", "MANAGED_TABLE", 
"MANAGED_TABLE", "MANAGED_TABLE");
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/14164/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java@296
PS2, Line 296:             "MANAGED_TABLE", "MANAGED_TABLE", "MANAGED_TABLE", 
"MANAGED_TABLE", "MANAGED_TABLE");
line too long (97 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/14164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57aca1fa74df36b1cd33e2d3e412c16ec0b15f4
Gerrit-Change-Number: 14164
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Fri, 30 Aug 2019 08:02:16 +0000
Gerrit-HasComments: Yes

Reply via email to