Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 ...................................................................... Patch Set 6: (4 comments) I'm ok if you want to +2 without waiting for thomas, just depends if you want more eyes on it. http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl File www/catalog.tmpl: http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@26 PS6, Line 26: h2 > The first three card titles look super huge now. Could we change it to h4? Done http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@72 PS6, Line 72: h2 > Same here. Done http://gerrit.cloudera.org:8080/#/c/14119/6/www/catalog.tmpl@116 PS6, Line 116: h2 > Same here Done http://gerrit.cloudera.org:8080/#/c/14119/6/www/threadz.tmpl File www/threadz.tmpl: http://gerrit.cloudera.org:8080/#/c/14119/6/www/threadz.tmpl@29 PS6, Line 29: h3 > nit: Can we change these 'h3' to 'h4'? Now they look much larger than befor Done -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 30 Aug 2019 17:45:03 +0000 Gerrit-HasComments: Yes
