Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 )
Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/14104/6/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/14104/6/be/src/runtime/coordinator-backend-state.h@470 PS6, Line 470: BackendReleased > BackendsReleased()? Done http://gerrit.cloudera.org:8080/#/c/14104/6/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/14104/6/be/src/runtime/coordinator-backend-state.cc@790 PS6, Line 790: DEFINE_uint32_hidden(batched_release_decay_factor, 2, > We pretty much always put flag definitions and declarations at the top of t Moved it to a separate file. http://gerrit.cloudera.org:8080/#/c/14104/6/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/14104/6/be/src/runtime/coordinator.cc@773 PS6, Line 773: backend_released_barrier_.Notify(); > Looks like we could add a Notify() method that took a count as the argument Thought about it a bit, think there are some subtle race conditions in CountingBarrier that I would rather not tackle right now unless necessary. -- To view, visit http://gerrit.cloudera.org:8080/14104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bb11e0ede7574568020e0277dd8ac8d2586dc9 Gerrit-Change-Number: 14104 Gerrit-PatchSet: 6 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Sep 2019 18:16:14 +0000 Gerrit-HasComments: Yes
