Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14134 )
Change subject: IMPALA-8797: Support database and table blacklist ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/14134/10/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java File fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java: http://gerrit.cloudera.org:8080/#/c/14134/10/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java@104 PS10, Line 104: if (BLACKLISTED_TABLES.contains(table)) { > Can we just do TableName temp = analyzer.getFqTableName(table); But there are no "analyzer" object here... Even if we move this "verifyTableName" function into Analyzer, there are no analyzer objects in TableName.analyze()... We still need to call "getFqTableName" in somewhere with the analyzer object... -- To view, visit http://gerrit.cloudera.org:8080/14134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02dbb07f8e08793b57b2a88d09b30fd32cff26dc Gerrit-Change-Number: 14134 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2019 00:52:04 +0000 Gerrit-HasComments: Yes
