Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14157 )
Change subject: IMPALA-7312: Non-blocking mode for Fetch() RPC ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14157/5/be/src/exec/blocking-plan-root-sink.cc File be/src/exec/blocking-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/14157/5/be/src/exec/blocking-plan-root-sink.cc@124 PS5, Line 124: bool timed_out = > Might be simpler to initialise to false. Done http://gerrit.cloudera.org:8080/#/c/14157/5/be/src/exec/blocking-plan-root-sink.cc@137 PS5, Line 137: (uint64_t) 1 > nit: shouldn't use c-style cast Done http://gerrit.cloudera.org:8080/#/c/14157/5/be/src/exec/buffered-plan-root-sink.cc File be/src/exec/buffered-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/14157/5/be/src/exec/buffered-plan-root-sink.cc@163 PS5, Line 163: PlanRootSink::fetch_rows_timeout_us() <= wait_timeout_timer.ElapsedTime(); > Might be simpler to initialise to false. I think we probably want to try at Done -- To view, visit http://gerrit.cloudera.org:8080/14157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I331acaba23a65dab43cca48e9dc0dc957b9c632d Gerrit-Change-Number: 14157 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2019 17:54:14 +0000 Gerrit-HasComments: Yes
