Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14143 )

Change subject: IMPALA-8572: Log query events before unregister.
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/14143/5/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/14143/5/tests/common/impala_test_suite.py@335
PS5, Line 335: ;
flake8: E703 statement ends with a semicolon


http://gerrit.cloudera.org:8080/#/c/14143/5/tests/common/impala_test_suite.py@646
PS5, Line 646: )
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/14143/5/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

http://gerrit.cloudera.org:8080/#/c/14143/5/tests/common/test_result_verifier.py@22
PS5, Line 22: import json
flake8: F401 'json' imported but unused


http://gerrit.cloudera.org:8080/#/c/14143/5/tests/common/test_result_verifier.py@631
PS5, Line 631: def verify_lineage(expected, actual, 
lineage_skip_json_keys=DEFAULT_LINEAGE_SKIP_KEYS):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/14143/5/tests/common/test_result_verifier.py@635
PS5, Line 635: p
flake8: E501 line too long (102 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/14143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I639b9c1acb9806b29292cd85be2863688453ca2e
Gerrit-Change-Number: 14143
Gerrit-PatchSet: 5
Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com>
Gerrit-Comment-Date: Thu, 05 Sep 2019 23:39:57 +0000
Gerrit-HasComments: Yes

Reply via email to