Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14184
Change subject: IMPALA-8917: Remove hostname from webui links if Knox isn't being used ...................................................................... IMPALA-8917: Remove hostname from webui links if Knox isn't being used IMPALA-8897 added the hostname to all links on the debug webui in order to facilitate proxying connections through Apache Knox. This makes the webui difficult to use in situations where the hostname is not DNS-resolvable. This patch fixes this by only including the hostname with links if Knox proxying is actually being used, which we determine by looking for the 'host' parameter in the request, which is used by Knox to determine what impalad host to connect to. It removes the hidden form fields that were added to support Knox integration when not being accessed through Knox. It also adds a class comment on Webserver explaining the requirements for keeping the webui compatible with Knox. Testing: - Added a test that checks that links on the webui are made absolute when the 'host' parameter is in the request. Change-Id: I0ca88115ef4a0fe2d68f1e9ee5fcc4bb415a2d85 --- M be/src/util/webserver.cc M be/src/util/webserver.h M tests/webserver/test_web_pages.py M www/form-hidden-inputs.tmpl 4 files changed, 48 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/14184/1 -- To view, visit http://gerrit.cloudera.org:8080/14184 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0ca88115ef4a0fe2d68f1e9ee5fcc4bb415a2d85 Gerrit-Change-Number: 14184 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
