Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14188 )
Change subject: IMPALA-8923: remove synchronized in HBaseTable.getEstimatedRowStats ...................................................................... Patch Set 3: (3 comments) Thanks for looking into this! Adjusted some logging based on comments. http://gerrit.cloudera.org:8080/#/c/14188/2/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java File fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java: http://gerrit.cloudera.org:8080/#/c/14188/2/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@369 PS2, Line 369: if (LOG.isTraceEnabled()) { > nit: use parameterized logging, {}... Done http://gerrit.cloudera.org:8080/#/c/14188/2/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@438 PS2, Line 438: if (LOG.isTraceEnabled()) { > same. Probably helps to dump the timetaken too. Done http://gerrit.cloudera.org:8080/#/c/14188/2/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@652 PS2, Line 652: long startTime = System.currentTimeMillis(); > intentional? Yea, want to know time used in getting region locations (querying HBase META table). Added log to show actual time used. -- To view, visit http://gerrit.cloudera.org:8080/14188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa23c16ee662c4f22851c700aea2ea5be847b64d Gerrit-Change-Number: 14188 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 06 Sep 2019 23:23:17 +0000 Gerrit-HasComments: Yes
