Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14199 )

Change subject: IMPALA-8917: Remove hostname from webui links if Knox isn't 
being used
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14199/1/be/src/util/webserver.h
File be/src/util/webserver.h:

http://gerrit.cloudera.org:8080/#/c/14199/1/be/src/util/webserver.h@51
PS1, Line 51: /// In order to be compatible with the Knox 'impalaui' service 
definition, there are a few
> Can you link to the knox service definition? It's discoverable by googling
Done



--
To view, visit http://gerrit.cloudera.org:8080/14199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf77058dc6ce1d72422a9e3ca7868cdffacff76
Gerrit-Change-Number: 14199
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 10 Sep 2019 01:54:03 +0000
Gerrit-HasComments: Yes

Reply via email to