Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14198 )
Change subject: IMPALA-8904: retry statestore RegisterSubscriber() RPC ...................................................................... IMPALA-8904: retry statestore RegisterSubscriber() RPC Previously connection failures triggered a retry, but failures on the actual RPC did not trigger a retry. This change moves the retry loop to DoRpcWithRetry(), instead of relying on the ClientCache to retry the connection. Note that DoRpcWithRetry() for thrift was dead code since most backend RPCs were ported to KRPC, but should still work. Testing: Added targeted test with debug action to inject error on first subscribe RPC. Change-Id: I5d4e6283b5ec83170a1d1d03075b3384a9f108b5 Reviewed-on: http://gerrit.cloudera.org:8080/14198 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/client-cache.h M be/src/statestore/statestore-subscriber.cc A tests/custom_cluster/test_statestore_rpc_errors.py 3 files changed, 77 insertions(+), 16 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5d4e6283b5ec83170a1d1d03075b3384a9f108b5 Gerrit-Change-Number: 14198 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
