Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14059 )

Change subject: PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/14059/5/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java:

http://gerrit.cloudera.org:8080/#/c/14059/5/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@175
PS5, Line 175:     RunShellCommand.Run(command, /* shouldSucceed */ false, "", 
"Not connected to Impala");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/14059/5/tests/util/run_impyla_http_query.py
File tests/util/run_impyla_http_query.py:

http://gerrit.cloudera.org:8080/#/c/14059/5/tests/util/run_impyla_http_query.py@30
PS5, Line 30: def run_query(query, args):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/14059/5/tests/util/run_impyla_http_query.py@33
PS5, Line 33: u
flake8: F841 local variable 'url' is assigned to but never used


http://gerrit.cloudera.org:8080/#/c/14059/5/tests/util/run_impyla_http_query.py@46
PS5, Line 46: def main():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/14059/5/tests/util/run_impyla_http_query.py@57
PS5, Line 57: if __name__ == "__main__":
flake8: E305 expected 2 blank lines after class or function definition, found 1



--
To view, visit http://gerrit.cloudera.org:8080/14059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018
Gerrit-Change-Number: 14059
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 12 Sep 2019 00:04:53 +0000
Gerrit-HasComments: Yes

Reply via email to