Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14183 )
Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries ...................................................................... Patch Set 2: (1 comment) As discussed offline, added a pseudo empty exec groups that we use only for scheduling coord only queries. I skipped making changes to the AssignmentCtx since it was turning out to be a bit unwieldy. We can take it up as clean up in the future. http://gerrit.cloudera.org:8080/#/c/14183/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/14183/2/be/src/scheduling/admission-controller.cc@a690 PS2, Line 690: : : : : : : : : : : : : : : : : : : : : : like we discussed offline, got rid of these checks that dont make sense for groups. -- To view, visit http://gerrit.cloudera.org:8080/14183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fe098032744aa20bbbe4faddfc67e7a46ce03d5 Gerrit-Change-Number: 14183 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Thu, 12 Sep 2019 20:16:31 +0000 Gerrit-HasComments: Yes
