Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC ...................................................................... Patch Set 19: (1 comment) There is an additional note added to the comments on Line 1117. Thanks! http://gerrit.cloudera.org:8080/#/c/13882/18/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/13882/18/be/src/runtime/coordinator.cc@1115 PS18, Line 1115: if (!status.ok()) { : LOG(ERROR) << "Cannot get inbound sidecar: " << status.message().ToString(); : Disable(coord->filter_mem_tracker_); > Thanks very much for the detailed explanation! I think the observation above actually indicates that even though the Bloom filter fed to RuntimeFilterBank::PublishGlobalFilter() corresponds to an always false filter, our current implementation will still call BloomFilter::Init() to allocate the memory space, which seems like a redundant and wasteful operation because the allocated Bloom filter is basically a bit array of all 0's. Maybe we could also simplify the current logic in a follow-up JIRA. -- To view, visit http://gerrit.cloudera.org:8080/13882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b394796d250286510e157ae326882bfc01d387a Gerrit-Change-Number: 13882 Gerrit-PatchSet: 19 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 12 Sep 2019 22:33:52 +0000 Gerrit-HasComments: Yes
