Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 )
Change subject: IMPALA-8825: Add additional counters to PlanRootSink ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14180/1/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/14180/1/be/src/service/client-request-state.h@421 PS1, Line 421: /// The number of rows materialized for this query, the counter is not reset if the : /// fetch is restarted. It does not include any rows read from the results cache, since : /// those rows are already materialized. : RuntimeProfile::Counter* rows_materialized_counter_ = nullptr; > yeah, this is pretty similar to num_rows_fetched_counter_ the difference is It seems a tad confusing to users to interpret these two counters. In essence, these counters only differ if the user somehow restarts the fetch. It may be simpler to just track the number of rows fetched from result cache using a separate counter and have a single counter for number of rows materialized. -- To view, visit http://gerrit.cloudera.org:8080/14180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9e101e2f3e2bf8324e149c780d35825ceecc036 Gerrit-Change-Number: 14180 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 13 Sep 2019 18:36:37 +0000 Gerrit-HasComments: Yes
