Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 )
Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader ...................................................................... Patch Set 17: (1 comment) Some information for reviewers: I started this refactor and later asked Danial to finish it, which led to quite big changes. It may help to look at the change in two steps: 1. till PS 3 - I tried to use mainly copy paste to avoid changing existing logic 2. rest of the review - several small logic changes were done to make the interfaces + code cleaner http://gerrit.cloudera.org:8080/#/c/13329/17/be/src/exec/parquet/parquet-page-reader-low.cc File be/src/exec/parquet/parquet-page-reader-low.cc: http://gerrit.cloudera.org:8080/#/c/13329/17/be/src/exec/parquet/parquet-page-reader-low.cc@37 PS17, Line 37: #include "util/codec.h" This header is not needed in this - can you look through the change for other unnecessary header files? -- To view, visit http://gerrit.cloudera.org:8080/13329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0289394adcb97a3529313030930c9c5b85aaa12 Gerrit-Change-Number: 13329 Gerrit-PatchSet: 17 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Sep 2019 13:03:10 +0000 Gerrit-HasComments: Yes
