Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 )
Change subject: IMPALA-7637: Add more hash table stats to profile ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14234/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14234/1//COMMIT_MSG@17 PS1, Line 17: Hash Join Builder (join_node_id=2): : ExecOption: Codegen Disabled: disabled due to optimization hints : Runtime filters: 1 of 1 Runtime Filter Published : - BuildRowsPartitionTime: 157.960us : - BuildRowsPartitioned: 100 (100) : - HashTablesBuildTime: 298.817us : - LargestPartitionPercent: 7 (7) : - MaxPartitionLevel: 0 (0) : - NumRepartitions: 0 (0) : - PartitionsCreated: 16 (16) : - PeakMemoryUsage: 17.12 KB (17536) : - RepartitionTime: 0.000ns : - SpilledPartitions: 0 (0) : Hash Table: : - HashBuckets: 256 (256) : - HashCollisions: 0 (0) : - Probes: 2.52K (2520) : - Resizes: 0 (0) : - Travel: 1.79K (1787) nit: don't think this has to be indented so much, just two spaces is probably sufficient, plus the `ExecOption` line is exceeding the max width of the commit message. http://gerrit.cloudera.org:8080/#/c/14234/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/14234/1/tests/query_test/test_observability.py@675 PS1, Line 675: assert "Hash Table" in runtime_profile : assert "Probes:" in runtime_profile : assert "Travel:" in runtime_profile : assert "HashCollisions:" in runtime_profile : assert "Resizes:" in runtime_profile would be good to validate that they have valid values - e.g. they are non-zero. not sure that would apply to all of these (e.g. resizes), but it would be good to add the validation for the ones that are non-zero. -- To view, visit http://gerrit.cloudera.org:8080/14234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87 Gerrit-Change-Number: 14234 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Sep 2019 16:55:08 +0000 Gerrit-HasComments: Yes
