Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 )
Change subject: IMPALA-8634: Catalog client should retry RPCs ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14246/1/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/14246/1/be/src/exec/catalog-op-executor.cc@62 PS1, Line 62: static Status CatalogRpcDebugFn(int* attempt) { > nit: pass as a pointer Done http://gerrit.cloudera.org:8080/#/c/14246/2/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/14246/2/be/src/exec/catalog-op-executor.cc@63 PS2, Line 63: return (*attempt)++ == 0 ? DebugAction(FLAGS_debug_actions, "CATALOG_RPC_FIRST_ATTEMPT") : > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/14246/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/14246/1/be/src/runtime/exec-env.cc@142 PS1, Line 142: DEFINE_int32(catalog_client_connection_num_retries, 3, "The number of times connections " > I kinda wonder if we should tweak the defaults to make it poll more frequen Yeah, 10 seconds does seem a little long. How about 10 retries, with an interval of 3 seconds? This way it still waits 30 seconds, but it just retries more often. -- To view, visit http://gerrit.cloudera.org:8080/14246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f33ad2b36d301fb64e70a939e71decab0ca993c Gerrit-Change-Number: 14246 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 18 Sep 2019 01:41:13 +0000 Gerrit-HasComments: Yes
