Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14059 )

Change subject: PREVIEW IMPALA-8863: Add support to run tests over HTTP/HS2
......................................................................


Patch Set 7:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/14059/7/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java:

http://gerrit.cloudera.org:8080/#/c/14059/7/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@175
PS7, Line 175:     RunShellCommand.Run(command, /* shouldSucceed */ false, "", 
"Not connected to Impala");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/14059/7/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/14059/7/tests/common/impala_test_suite.py@237
PS7, Line 237: n
flake8: E713 test for membership should be 'not in'


http://gerrit.cloudera.org:8080/#/c/14059/7/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/14059/7/tests/shell/test_shell_interactive.py@28
PS7, Line 28: from contextlib import contextmanager
flake8: F401 'contextlib.contextmanager' imported but unused


http://gerrit.cloudera.org:8080/#/c/14059/7/tests/util/run_impyla_http_query.py
File tests/util/run_impyla_http_query.py:

http://gerrit.cloudera.org:8080/#/c/14059/7/tests/util/run_impyla_http_query.py@30
PS7, Line 30: def run_query(query, args):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/14059/7/tests/util/run_impyla_http_query.py@33
PS7, Line 33: u
flake8: F841 local variable 'url' is assigned to but never used


http://gerrit.cloudera.org:8080/#/c/14059/7/tests/util/run_impyla_http_query.py@46
PS7, Line 46: def main():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/14059/7/tests/util/run_impyla_http_query.py@57
PS7, Line 57: if __name__ == "__main__":
flake8: E305 expected 2 blank lines after class or function definition, found 1



--
To view, visit http://gerrit.cloudera.org:8080/14059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018
Gerrit-Change-Number: 14059
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 00:43:04 +0000
Gerrit-HasComments: Yes

Reply via email to