Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14266 )
Change subject: IMPALA-4057, IMPALA-4050: Fix --webserver_interface ...................................................................... IMPALA-4057, IMPALA-4050: Fix --webserver_interface This patch fixes two issues with --webserver_interface: - When --webserver_interface was used start-impala-cluster.py with a value that's different from --hostname, minicluster startup would appear to fail as liveness is determined by checking for the webui's availability at the address specified for --hostname. - The value of --webserver_interface was applied correctly for the catalogd and statestored but not for impalads, due to the way ExecEnv constructed the Webserver. - It is now possible to specify a hostname for webserver_interface instead of an IP. The webserver will resolve the hostname. This patch also upgrades our version of psutil to the latest for the function 'net_if_addrs'. This requires a few change to our use of psutil, mostly adding '()' to call functions that previously were variables. Testing: - Added a custom cluster test that finds all available interfaces, binds the webserver to one of them, and checks that its only available over that interface. Change-Id: Ic7e75908426756d73f13a0fa3cfc21fc31da164c Reviewed-on: http://gerrit.cloudera.org:8080/14266 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/runtime/exec-env.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h M infra/python/deps/compiled-requirements.txt M tests/common/impala_cluster.py M tests/common/impala_service.py M tests/common/impala_test_suite.py M tests/custom_cluster/test_client_ssl.py M tests/custom_cluster/test_web_pages.py 10 files changed, 112 insertions(+), 64 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic7e75908426756d73f13a0fa3cfc21fc31da164c Gerrit-Change-Number: 14266 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
