Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-8795 : Enable event polling by default in dockerized tests.
> Should be "in dockerized tests" - this makes it sound like it's enabled for
Done


http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG@13
PS1, Line 13: Testing:
> Can update this now?
Done


http://gerrit.cloudera.org:8080/#/c/14272/1/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/14272/1/tests/custom_cluster/test_event_processing.py@a43
PS1, Line 43:
> It doesn't really make sense to remove thse execute_serially markers for cu
Done


http://gerrit.cloudera.org:8080/#/c/14272/1/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/14272/1/tests/util/event_processor_utils.py@45
PS1, Line 45: is_hive_inse
> should be is_hive_insert
Done



--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <[email protected]>
Gerrit-Reviewer: Anurag Mantripragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Fri, 20 Sep 2019 21:33:30 +0000
Gerrit-HasComments: Yes

Reply via email to