Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14280
Change subject: IMPALA-8946: Fix histogram rendering to Prometheus ...................................................................... IMPALA-8946: Fix histogram rendering to Prometheus Prometheus has two formats that allows to calculate quantiles (on client side): Histograms and Summaries. The former requires to pick a set of buckets, while the latter only requires to specifiy which quantiles (percentiles) the application wants to provide. The difference between summaries and histograms on Prometheus can be found here: https://prometheus.io/docs/practices/histograms/ Previous to this changes, Impala histograms were rendered as Prometheus histograms, but it was calculating percentiles instead of bucketing the recorded values, which is not what Prometheus clients expects. >From now on, Impala histograms will be rendered as Prometheus summaries instead, which expects quantiles. Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 --- M be/src/util/histogram-metric.cc M be/src/util/metrics-test.cc 2 files changed, 53 insertions(+), 71 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/14280/1 -- To view, visit http://gerrit.cloudera.org:8080/14280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8849586964140c040ca4ea14b777c2d98d126b59 Gerrit-Change-Number: 14280 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]>
