Hello Michael Ho, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14242
to look at the new patch set (#2).
Change subject: IMPALA-8884: track storage read statistics per queue
......................................................................
IMPALA-8884: track storage read statistics per queue
Adds the following metrics for each queue:
* impala-server.io-mgr.queue-$i.device-name
* impala-server.io-mgr.queue-$i.read-latency
* impala-server.io-mgr.queue-$i.read-size
I also looked at adding metrics for open operations,
but the plumbing got messy since the code paths
where hdfsOpen() is invoked are more numerous and
complex (e.g. HDFS caching does it outside of a
disk thread).
Perf:
Histograms use atomic operations, so lock contention
isn't an issue.
Ran a TPC-H benchmark on scale factor 30 locally,
saw no perf change.
Change-Id: I8233ed02b418f22f1d0c031e378288357796f4b4
---
M be/src/runtime/exec-env.cc
M be/src/runtime/io/cache-reader-test-stub.h
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr.cc
M be/src/runtime/io/file-reader.h
M be/src/runtime/io/hdfs-file-reader.cc
M be/src/runtime/io/hdfs-file-reader.h
M be/src/runtime/io/local-file-reader.cc
M be/src/runtime/io/local-file-reader.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/runtime/test-env.cc
M be/src/service/impala-server.cc
M be/src/util/histogram-metric.h
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
17 files changed, 216 insertions(+), 118 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/14242/2
--
To view, visit http://gerrit.cloudera.org:8080/14242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8233ed02b418f22f1d0c031e378288357796f4b4
Gerrit-Change-Number: 14242
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
