Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14294 )
Change subject: IMPALA-8928: Add MEM_LIMIT_EXECUTORS query option ...................................................................... Patch Set 1: Code-Review+2 (2 comments) This looks nice and simple. http://gerrit.cloudera.org:8080/#/c/14294/1/be/src/scheduling/query-schedule.cc File be/src/scheduling/query-schedule.cc: http://gerrit.cloudera.org:8080/#/c/14294/1/be/src/scheduling/query-schedule.cc@344 PS1, Line 344: if (!has_query_option && query_options().__isset.mem_limit_executors I had to look at a broader context to understand that 'has_query_limit' means 'has the MEM_LIMIT query option', not just any query option. http://gerrit.cloudera.org:8080/#/c/14294/1/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/14294/1/common/thrift/ImpalaService.thrift@482 PS1, Line 482: // otherwise specified either as: Nit: capitalize 'Otherwise' -- To view, visit http://gerrit.cloudera.org:8080/14294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20dfd4e8fc7ffd9130db9f942efa78965c724e18 Gerrit-Change-Number: 14294 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Sep 2019 23:11:56 +0000 Gerrit-HasComments: Yes
