Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14289 )
Change subject: IMPALA-8647: fix round-to-zero in planner estimates ...................................................................... Patch Set 1: Code-Review+2 (3 comments) lgtm, just some comments about possible cleanups http://gerrit.cloudera.org:8080/#/c/14289/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/14289/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@352 PS1, Line 352: // IMPALA-2165: Avoid setting the cardinality to 0 after rounding. : cardinality_ = Math.max(1, cardinality_); This seems redundant. http://gerrit.cloudera.org:8080/#/c/14289/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/14289/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1148 PS1, Line 1148: // IMPALA-2165: Avoid setting the cardinality to 0 after rounding. : cardinality_ = Math.max(cardinality_, 1); This is redundant now. http://gerrit.cloudera.org:8080/#/c/14289/1/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/14289/1/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@267 PS1, Line 267: cardinality_ = Math.min(Math.max(1, cardinality_), kuduTable_.getNumRows()); If applyConjunctsSelectivity() cannot increase cardinality, then this seems redundant. -- To view, visit http://gerrit.cloudera.org:8080/14289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I148e9f1aede0a1e99b875b0e6af534f4bccf49b7 Gerrit-Change-Number: 14289 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2019 14:49:46 +0000 Gerrit-HasComments: Yes
