Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 )
Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. ...................................................................... Patch Set 6: (3 comments) Still have one more question and a nit http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1226 PS6, Line 1226: nit: wrong indent here http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1313 PS6, Line 1313: catalog_.addVersionsForInflightEvents(db, newCatalogVersion); Could you explain why we don't need this for persistent java functions? In previous patch versions, it's in the if-branch below. http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2017 PS6, Line 2017: catalog_.addVersionsForInflightEvents(db, newCatalogVersion); same here. -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 6 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 27 Sep 2019 19:00:20 +0000 Gerrit-HasComments: Yes
