Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 )
Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/common/status.cc File be/src/common/status.cc: http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/common/status.cc@160 PS1, Line 160: apache::hive::service::cli::thrift::TStatusCode Maybe add a 'using TStatusCode' to this file so the formatting here isn't so awful? http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h@108 PS1, Line 108: ( typo? http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.h@114 PS1, Line 114: wait for typo? http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc@786 PS1, Line 786: void ClientRequestState::BlockOnWait() { Could we reduce some duplication by just calling BlockOnWait(0) here? http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/client-request-state.cc@809 PS1, Line 809: block_on_wait_cv_.Wait(l); So if I understand correctly, here if 'timeout' is 0 we wait indefinitely but in the (Buffered|Blocking)PlanRootSink::GetNext if 'timeout' is 0 we don't wait at all. Is that intentional? It would be good to document the expected behavior for a '0' timeout http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/14332/1/be/src/service/impala-hs2-server.cc@860 PS1, Line 860: return_val.status.__set_statusCode(thrift::TStatusCode::SUCCESS_STATUS); did you mean to make this change? -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2019 17:50:38 +0000 Gerrit-HasComments: Yes
