Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling ...................................................................... Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml File docs/topics/impala_fetch_rows_timeout_ms.xml: http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46 PS1, Line 46: </p> > I think it should be documented, it is potentially impactful for any users Done http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@51 PS1, Line 51: 10 > The query option has "MS" in the name, implying the unit. I added "10 Secon Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml File docs/topics/impala_fetch_rows_timeout_ms.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@40 PS3, Line 40: TRUE > should be false Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@43 PS3, Line 43: FALSE > should be true Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@47 PS3, Line 47: Only positive values are allowed > sorry, just fixed a bug with this and now a value of 0 for FETCH_ROWS_TIMEO Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml File docs/topics/impala_query_results_spooling.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@43 PS3, Line 43: POOL_QUERY_RESULTS > SPOOL_QUERY_RESULTS Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@78 PS3, Line 78: TRUE > FALSE Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@81 PS3, Line 81: FALSE > TRUE Done http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml File docs/topics/impala_spool_query_results.xml: http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml@36 PS3, Line 36: <p>Use the <codeph>SPOOL_QUERY_RESULTS</codeph> query option to enable query : result spooling, which is disabled by default.</p> : <p>Query result spooling controls how rows are returned to the client. <ul> : <li>When query result spooling is disabled, Impala relies on clients to : fetch results to trigger the generation of more result row batches : until all the result rows have been produced. If a client issues a : query without fetching all the results, the query fragments will : continue to consume the resources until the query is cancelled and : unregistered, potentially tying up resources and cause other queries : to wait for extended period of time in admission control.</li> : <li>When query result spooling is enabled, result sets of queries are : eagerly fetched and spooled in the spooling location on a persistent : storage, either in memory or on disk. <p>Once all result rows have : been fetched and stored in the spooling location, the resources are : freed up. Incoming client fetches can get the data from this spooled : locations.</p></li> : </ul></p> > I think some of the review comments from impala_query_results_spooling.xml attempted -- To view, visit http://gerrit.cloudera.org:8080/14314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe Gerrit-Change-Number: 14314 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2019 22:42:27 +0000 Gerrit-HasComments: Yes
