Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 )
Change subject: IMPALA-8498: Write column index for floating types when NaN is not present ...................................................................... Patch Set 6: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/14264/6/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/14264/6/be/src/exec/parquet/hdfs-parquet-table-writer.cc@436 PS6, Line 436: //UNLIKELY( remove? http://gerrit.cloudera.org:8080/#/c/14264/6/be/src/exec/parquet/hdfs-parquet-table-writer.cc@470 PS6, Line 470: // IMPALA-7304: Don't write column index for floating-point columns until : // PARQUET-1222 is resolved. This is modified by: : // IMPALA-8498: Write column index for floating types when NaN is not present nit: I think that mentioning IMPALA-7304 just make this comment more confusing. http://gerrit.cloudera.org:8080/#/c/14264/6/tests/query_test/test_parquet_page_index.py File tests/query_test/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/14264/6/tests/query_test/test_parquet_page_index.py@305 PS6, Line 305: nit: extra line (we generally leave only 1 line between functions) http://gerrit.cloudera.org:8080/#/c/14264/6/tests/query_test/test_parquet_page_index.py@466 PS6, Line 466: unique_database, no_nan_tbl, : "(1.5), (2.3), (4.5), (42.42), (3.1415), (0.0)") here and at several other lines: needs + 4 indentation -- To view, visit http://gerrit.cloudera.org:8080/14264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9d367500243c8ca142a16ebfeef6c841f013434 Gerrit-Change-Number: 14264 Gerrit-PatchSet: 6 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2019 15:56:50 +0000 Gerrit-HasComments: Yes
