Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14325 )
Change subject: IMPALA-2138: part 3: refactor analytic planning ...................................................................... IMPALA-2138: part 3: refactor analytic planning This is a minor refactor of the analytic planner that moves the logic to generate a "buffered tuple descriptor" and equality expressions to the AnalyticEvalNode. This is required for projection, because the buffered tuple layout is required to match the input tuple layout, so needs to be updated if the input tuple is projected. After the refactoring, this can be correctly updated simply by regenerating the tuple descriptor and expressions, instead of attempting to "fix up" the existing expressions with smaps, etc. I think the plan node is actually a more approprate place for this logic regardless, since it's tightly entwined with the backend's assumption that the two tuple layouts are identical. Change-Id: I691f1509a85cad51d2654278c0a4ba70a10b2706 Reviewed-on: http://gerrit.cloudera.org:8080/14325 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java 3 files changed, 123 insertions(+), 127 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I691f1509a85cad51d2654278c0a4ba70a10b2706 Gerrit-Change-Number: 14325 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
