Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14344 )
Change subject: IMPALA-8997: auto fallback to mt_dop=0 ...................................................................... Patch Set 8: (3 comments) One failure was a flaky test that I think failed because it assumed that queries started up within 5 seconds of submission (which is untrue with admission control enabled). I marked that as serial. The planner test failure was because the output on my local system was slightly different, I think because I didn't have a clean data load. http://gerrit.cloudera.org:8080/#/c/14344/8/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/14344/8/be/src/common/global-flags.cc@273 PS8, Line 273: "(Experimental) If true, fall back to non-mt_dop if mt_dop is set and a query " > nit: "if mt_dop query option is set" Done http://gerrit.cloudera.org:8080/#/c/14344/8/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14344/8/fe/src/main/java/org/apache/impala/service/Frontend.java@1427 PS8, Line 1427: on Parquet/ORC tables > nit: update comment Done http://gerrit.cloudera.org:8080/#/c/14344/8/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/14344/8/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@665 PS8, Line 665: "select * from functional_parquet.alltypes", mtDop, effectiveMtDop); > nit: how about: Done -- To view, visit http://gerrit.cloudera.org:8080/14344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d73d8744059874293697c8e104891a10dba04d Gerrit-Change-Number: 14344 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Oct 2019 23:36:03 +0000 Gerrit-HasComments: Yes
