Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14357 )
Change subject: IMPALA-8998: admission control accounting for mt_dop ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/14357/12/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/14357/12/be/src/scheduling/admission-controller.cc@247 PS12, Line 247: const string HOST_SLOT_NOT_AVAILABLE = "Not enough query slots available on host $0. " > I think we should remove all usages of the term 'query slot'. Done. Good point. http://gerrit.cloudera.org:8080/#/c/14357/12/be/src/scheduling/admission-controller.cc@573 PS12, Line 573: << " admission_slots=" << admission_slots; > Nit: "executor admission_slots" might be more readable Done -- To view, visit http://gerrit.cloudera.org:8080/14357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b6b6262ef238df26b491352656a26e4163e46e5 Gerrit-Change-Number: 14357 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 08 Oct 2019 04:24:18 +0000 Gerrit-HasComments: Yes