Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14385 )
Change subject: IMPALA-9017: Alter table events on dropped table/db should be ignored. ...................................................................... Patch Set 1: (2 comments) Left some minor suggestions. Rest looks good to me. http://gerrit.cloudera.org:8080/#/c/14385/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14385/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@986 PS1, Line 986: // old table was not found. This could be because catalogD is stale and didn't : // have any entry for the oldTable Can you please update this comment? Its not relevant anymore http://gerrit.cloudera.org:8080/#/c/14385/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/14385/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@922 PS1, Line 922: alterTableRename may be add another case where the rename is from Impala too. You can use the method alterTableRenameFromImpala to do that. -- To view, visit http://gerrit.cloudera.org:8080/14385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I534accd704f76772ebe47865eff0fcdc7a033a48 Gerrit-Change-Number: 14385 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 08 Oct 2019 17:28:47 +0000 Gerrit-HasComments: Yes
