Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14372 )
Change subject: IMPALA-9008: Serialize Maven invocations to deflake impala-minimal-hive-exec ...................................................................... Patch Set 2: Code-Review+1 (1 comment) I think this makes sense (and I think you are right that this is a similar issue to IMPALA-7051). Thanks for taking this on. One small nit, then I'll bump to +2. http://gerrit.cloudera.org:8080/#/c/14372/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14372/2//COMMIT_MSG@13 PS2, Line 13: Similarly to the solution in IMPALA-7051, I try to fix it by : adding a fictional dependency to serialize the builds. Nit: One small thing. Can you add one line noting the order of dependencies like we had in the IMPALA-7051 comment. i.e. fe -> yarn-extras -> ext-data-source -> shaded-deps -> impala-parent And note that the yarn-extras, ext-data-source, shaded-deps are arbitrary. -- To view, visit http://gerrit.cloudera.org:8080/14372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic951ad7313e5ad9add2a00e6a442c6e97f235967 Gerrit-Change-Number: 14372 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 08 Oct 2019 20:52:44 +0000 Gerrit-HasComments: Yes
