Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14410 )

Change subject: IMPALA-9021: Fix the field of client's IP sent to Ranger
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14410/2/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
File fe/src/test/java/org/apache/impala/testutil/TestUtils.java:

http://gerrit.cloudera.org:8080/#/c/14410/2/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@365
PS2, Line 365:             defaultDb, user, new 
TNetworkAddress("::ffff:127.0.0.1", 0)));
I changed the first argument to the class of TNetworkAddress because 
InetAddresses.forString() at 
https://gerrit.cloudera.org/c/14410/2/fe/src/main/java/org/apache/impala/util/TSessionStateUtil.java#44
 is expecting an IP string literal instead of an arbitrary string, e.g., 
'localhost'.



--
To view, visit http://gerrit.cloudera.org:8080/14410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661ca4bb978d497df1fcf2765739cb8b4734d776
Gerrit-Change-Number: 14410
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Thu, 10 Oct 2019 18:07:29 +0000
Gerrit-HasComments: Yes

Reply via email to