Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14406 )
Change subject: IMPALA-9033: log on slow HDFS I/Os ...................................................................... Patch Set 2: Code-Review+2 (1 comment) This looks good to me. Very useful. http://gerrit.cloudera.org:8080/#/c/14406/1/be/src/runtime/io/hdfs-file-reader.cc File be/src/runtime/io/hdfs-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/14406/1/be/src/runtime/io/hdfs-file-reader.cc@178 PS1, Line 178: << PrettyPrinter::PrintBytes(*bytes_read + current_bytes_read) : << "/" << PrettyPrinter::PrintBytes(bytes_to_read) : << " starting at offset " << file_offset << " in this I/O scheduling " : << "quantum and taken " : << PrettyPrinter::Print(elapsed_time, TUnit::TIME_NS) << " so far. " : << "I/O status: " << (status.ok() ? "OK" : status.GetDetail()); : } : : if (!status.ok()) { : break; : } : DCHECK_GT(current_bytes_read, -1); : if (current_bytes_read == 0) { : // No more bytes in the file. The scan range went past the end. : > That's a good point, we really want to know in that case too. I think the approach makes sense. We don't want the logging to add a bunch of complexity. -- To view, visit http://gerrit.cloudera.org:8080/14406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1929921495706b482d91d91cffe27bee4478f5c4 Gerrit-Change-Number: 14406 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2019 19:29:17 +0000 Gerrit-HasComments: Yes
