Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14183 )
Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/14183/6/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/14183/6/be/src/scheduling/admission-controller.cc@a737 PS6, Line 737: Looks like this reason can't be returned any more. Was this deliberate? Is the idea that these queries will just get queued? Or that they'll fail a different check? http://gerrit.cloudera.org:8080/#/c/14183/6/be/src/scheduling/admission-controller.cc@a745 PS6, Line 745: Same with this one? -- To view, visit http://gerrit.cloudera.org:8080/14183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fe098032744aa20bbbe4faddfc67e7a46ce03d5 Gerrit-Change-Number: 14183 Gerrit-PatchSet: 6 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2019 22:08:02 +0000 Gerrit-HasComments: Yes
