Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14403 )
Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites properly ...................................................................... Patch Set 1: Code-Review+2 (1 comment) LGTM. I just have one ask http://gerrit.cloudera.org:8080/#/c/14403/1/testdata/workloads/functional-query/queries/QueryTest/alias.test File testdata/workloads/functional-query/queries/QueryTest/alias.test: http://gerrit.cloudera.org:8080/#/c/14403/1/testdata/workloads/functional-query/queries/QueryTest/alias.test@89 PS1, Line 89: # literal alias It would be good to include the JIRA here for future reference. Maybe also a one line comment explaining the bug too. -- To view, visit http://gerrit.cloudera.org:8080/14403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic57bf3f4cdabfe9c5bb304d735bfbf1c0ca7a274 Gerrit-Change-Number: 14403 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2019 23:28:40 +0000 Gerrit-HasComments: Yes
