Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14457 )
Change subject: IMPALA-9052 : Events processor should skip blacklisted database and tables ...................................................................... Patch Set 2: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/14457/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14457/2//COMMIT_MSG@7 PS2, Line 7: nit: I think we don't need space here http://gerrit.cloudera.org:8080/#/c/14457/2//COMMIT_MSG@9 PS2, Line 9: IMPALA-8797 introduced a configuration which can blacklist certain database and tables so nit: lines exceeding 72 characters. Though not part of our code style, it's more friendly for text wrapping in console tools. http://gerrit.cloudera.org:8080/#/c/14457/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14457/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@214 PS2, Line 214: Iterator<MetastoreEvent> it = metastoreEvents.iterator(); nit: non-used variable http://gerrit.cloudera.org:8080/#/c/14457/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@227 PS2, Line 227: + "blacklisted database or table.")); nit: should we log the db and table for better debuggability? -- To view, visit http://gerrit.cloudera.org:8080/14457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5a53b722e6225e9cad9954f447f821c2c677e60 Gerrit-Change-Number: 14457 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2019 23:56:59 +0000 Gerrit-HasComments: Yes
