Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 )
Change subject: IMPALA-9030: Handle translated external Kudu tables ...................................................................... Patch Set 8: (1 comment) > Patch Set 8: > > (3 comments) > > I think HDFS and HBase tables also have this issue. For example, creating a > non-transactional HDFS table will finally create an external table. Then in > DROP TABLE we won't drop HDFS files. > > However, let's keep this fix simple and focus on kudu first. Sorry, only managed Kudu tables are affected. For HDFS tables and HBase tables, Impala never remove underlying files or hbase tables. The removal works are done by Hive so they will always be right. http://gerrit.cloudera.org:8080/#/c/14397/8/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/14397/8/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@140 PS8, Line 140: public static boolean isSynchronizedTable( > Could you move these three functions into Table.java? I feel like it's not Sorry, don't need to move these... Only Kudu tables are affected. -- To view, visit http://gerrit.cloudera.org:8080/14397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324523361c923b7d291cb4d0f1028b1a5b653b36 Gerrit-Change-Number: 14397 Gerrit-PatchSet: 8 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Sat, 19 Oct 2019 15:16:47 +0000 Gerrit-HasComments: Yes
