Tim Armstrong has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14499 )
Change subject: IMPALA-9065: don't block indefinitely for filters ...................................................................... IMPALA-9065: don't block indefinitely for filters This patch ensures that query cancellation will promptly wake up any threads blocked waiting for runtime filters to arrive. Before this patch, threads would wait for up to RUNTIME_FILTER_WAIT_TIME_MS after the query was cancelled. Testing: * Add a cancellation test with a high runtime filter wait time that reproduces the threads getting stuck. This test failed reliably without the code changes. * Also update metric verification to check that no fragments are left running when tests are finished. * Ran exhaustive tests. * Ran a 10000 query TPC-H Kudu and TPC-DS Parquet stress test on a minicluster with 3 impalads. TODO: TPC-DS part. Change-Id: I0a70e4451c2b48c97f854246e90b71f6e5d67710 --- M be/src/exec/buffered-plan-root-sink.h M be/src/runtime/fragment-instance-state.cc M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/runtime-filter-bank.h M be/src/runtime/runtime-filter.cc M be/src/runtime/runtime-filter.h M be/src/runtime/runtime-filter.inline.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M tests/query_test/test_runtime_filters.py M tests/verifiers/metric_verifier.py 11 files changed, 141 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/14499/7 -- To view, visit http://gerrit.cloudera.org:8080/14499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a70e4451c2b48c97f854246e90b71f6e5d67710 Gerrit-Change-Number: 14499 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
